Add feature skip_roothints_download #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| File[$hints_file] -> Exec['download-roothints'] | ||
| } else { | ||
| Exec['download-roothints'] -> File[$hints_file] | ||
| } |
|
i was gonna say: can you add a spec tests, but we don't have any spec tests for this class now (other than whether it exists), so it wouldn't be fair on you… you should however document the feature in the readme! |
|
Yes, I thought about the readme after submitting, I'll submit that. Yeah, rspec and even general parameter validation is lacking in this module |
|
I tried to keep the documentation in the style of the readme, it's a bit different from regular modules which usually document all the parameters, hope this is ok. |
igalic
added a commit
that referenced
this pull request
Oct 14, 2015
Add feature skip_roothints_download
|
super! thank you @mrdima! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An option to skip the download of root.hins. There are many ways, I wanted to change as little as possible. Closes #103