unbound_version: add spec tests to the unbound_version fact #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test errors here look similar to what I was running into. |
b4ldr
force-pushed
the
add_facter_tests
branch
from
3f01c42
to
a0c4844
Compare
|
oh i forgot to fix rubocop errors should be god now edit: oh i see ruby 2.4 has errors will check |
|
strange this works on my laptop but not a fresh install, suspect something is missing from the Gemfile but not sure what just yet |
b4ldr
force-pushed
the
add_facter_tests
branch
3 times, most recently
from
625aaeb
to
4650046
Compare
|
Ok i think i got it, the fact was testing for the presence of the unbound binary. if it doesn't exist the fact will return nil and it doesn't exist in travis so we have to mock that a bit. |
b4ldr
force-pushed
the
add_facter_tests
branch
from
4650046
to
a57955f
Compare
|
Yay! Thank you for putting this up @b4ldr, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xaque208 here are some tests to replace the ones attempted in #173