Add functionality to render local data and override local-zone template: #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new param local_data which is an Array of Strings. local_data will be add into a configuration file as defined in a template. - Add a new param template_name. Therefore anybody can use a custom template.
b4ldr
reviewed
Dec 17, 2019
manifests/localzone.pp
Outdated
| # | ||
| define unbound::localzone ( | ||
| Unbound::Local_zone_type $type, | ||
| String $zone = $name, | ||
| $config_file = $unbound::config_file, | ||
| Array[String] $local_data = [], |
There was a problem hiding this comment.
it might be nice to create a custome type for resource records instead of just accepting any random string. something like
type unbound::local_data = Struct[{
name => String,
type => String,
data => String,
}]
]in yaml you would have
unbound::local_data:
- name: foobar
rrtype: A
data: 192.0.2.1
- name: foobar
rrtype: TXT
data: 'spf=foobar'
There was a problem hiding this comment.
This seems like a good suggestion to me. It will slightly complicate the template, but not much.
There was a problem hiding this comment.
Thanks for ideas. I adjusted PR.
|
This looks great. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localzone.pp. local_data will be add into a configuration file as defined in a template.localzone.pp. Therefore anybody can use a custom template.