Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #264

Merged
merged 1 commit into from Apr 26, 2021
Merged

Refactor #264

merged 1 commit into from Apr 26, 2021

Conversation

b4ldr
Copy link
Member

@b4ldr b4ldr commented Apr 20, 2021 •
edited

Pull Request (PR) description

  • $package_name is not optional as such remove the logic which assumes it is optional and specify the dependencies in place
  • drop create_resources() in favour of using each
  • for $dirs moving to using each allowed us to simplify the ownership issue

This Pull Request (PR) fixes the following issues

No bug fixes just a clean up

@b4ldr
Copy link
Member Author

b4ldr commented Apr 20, 2021

$package_name is not optional as such remove the logic which assumes it is optional and specify the dependencies in place
This is not true OpenBSD has this set to a blank string. we should make it Optional will fix this shortly

@b4ldr b4ldr force-pushed the refactor branch 6 times, most recently from ee00a9d to e124ec8 Compare April 21, 2021 16:02
@b4ldr
Refactor
ecd6b7b 
 * $package_name is not optional as such remove the logic to make it
   optional and specify the dependencies in place
 * drop create_resources() in favour of using each
 * for `$dirs` moving to using each allowed us to simplify the ownership
   issue
@b4ldr b4ldr requested a review from zachfi April 21, 2021 17:25
@b4ldr b4ldr merged commit d4ff283 into voxpupuli:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@zachfi zachfi Awaiting requested review from zachfi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@b4ldr @kenyon