Require Unbound 1.6.6 or newer

[b4ldr]

Pull Request (PR) description

This PR updates the minimum supported version of unbund. this allows
us to be a bit more generous when writing the first unbound.conf file
and fixes #286

I have picked unbound 1.6.6 as the minimum supported version. this
seems to be the version available in centos 7 which i assume is the
oldest version we support based on metatdata.json

This Pull Request (PR) fixes the following issues

Fixes: #286

[bastelfreak]

@b4ldr can you take a look at the failing tests?

[b4ldr]

@b4ldr can you take a look at the failing tests?

done, at least im pretty sure the unbound issues are unrelated but will double check

[ekohl]

This feels like a major version bump to me. Perhaps we should first merge the other open PRs, get a release out and then do this major? Either way, I'm fine.

[b4ldr]

This feels like a major version bump to me. Perhaps we should first merge the other open PRs, get a release out and then do this major?

SGTM

[vox-pupuli-tasks]

Dear @b4ldr, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[smortex]

LGTM, my only concern is that nothing says '1.6.6' in the code :-). I am not familiar with this code base, and I let you judge if it makes sense to have the print_config function raise an error when passed a version older than the oldest supported version so that the CI can help locating settings that need an update when we change this version.

[b4ldr]

This feels like a major version bump to me. Perhaps we should first merge the other open PRs, get a release out and then do this major? Either way, I'm fine.

done

LGTM, my only concern is that nothing says '1.6.6' in the code :-). I am not familiar with this code base, and I let you judge if it makes sense to have the print_config function raise an error when passed a version older than the oldest supported version so that the CI can help locating settings that need an update when we change this version.

personally i think its a bit overkill to add a minimum version in the print_config function. however we should state somewhere that the minimum version of unbound supported is 1.6.6. perhaps something in the metadata.json requirements block and.or something in the README.md?

[ekohl]

README is IMHO the best place.

[b4ldr]

updated

[smortex]

Looks fine, just the dubious requirement…