stub: add support for stub-first stub zone option #322
Conversation
Add support for stub-first stub zone option, which default to false. It allows queries to be attempted again without the stub clause if they failed with stub.
irregulator
force-pushed
the
feat/stub_first_option
branch
from
8bdde66
to
ecbd9df
Compare
|
I'm not quite sure why static validation fails, but I'll be happy to get feedback on how to fix it. |
|
It's saying that All of the documentation comments need to be updated to the new format: https://www.puppet.com/docs/puppet/8/puppet_strings.html |
Thanks @kenyon . |
irregulator
force-pushed
the
feat/stub_first_option
branch
from
ecbd9df
to
7e9f666
Compare
Add a spec test for the newly introduced stub-first option.
irregulator
force-pushed
the
feat/stub_first_option
branch
from
7e9f666
to
04db7ae
Compare
irregulator
force-pushed
the
feat/stub_first_option
branch
from
04db7ae
to
b0b3ae6
Compare
|
Okay I got static validations to pass. Now it's Centos 8 that's failing: https://github.com/voxpupuli/puppet-unbound/actions/runs/6275268917/job/17042416969 from the output am not sure if the timeout means that the acceptance command was never executed in the container or it was actually executed and failed. Any hints? |
|
That looks like a temporary network error. I just reran the job. |
|
Thanks! |
Pull Request (PR) description
Add support for stub-first stub zone option, which defaults to false.
It allows queries to be attempted again without the stub clause if
they failed with stub.
This Pull Request (PR) fixes the following issues