Add support of custom MSE config #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Mar 9, 2023
Comment on lines
+121
to
+124
| String[1] $version = present, | ||
| Boolean $add_repo = false, | ||
| Boolean $manage_firewall = false, | ||
| String $varnish_conf_template = 'varnish/varnish-conf.erb', | ||
| String[1] $varnish_conf_template = 'varnish/varnish-conf.erb', |
There was a problem hiding this comment.
nitpick: those changes are not related to the PR. Usually we try to split changes up into multiple PR so that all changes in one PR focus on one thing. I think in this case it's fine because the changes are quite small.
bastelfreak
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add the abillity to provide custom mse config. That config will be applied with mkfs.mse. So MSE can be used with file store.