add expected_response parameter for probes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My apologies, this commit is essentially identical but fixes the lint issue and rearranges to better match the existing style as a result. The failures on Oracle Linux 7 do not appear to be related to my changes but rather an inability to get the |
|
@jhunt-steds could you please rebase the MR, then the bugs should be fixed |
|
Thanks; I hope this is satisfactory. |
voxel01
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add the
expected_responseparameter to thevarnish::vcl::probeclass, along with documentation in REFERENCE.md.This Pull Request (PR) fixes the following issues
The
expected_responseprobe parameter has been missing since the maxchk days and was therefore not configurable by this module.