Feat: support retrieving secrets from non-puppet signed Vault listener #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Aug 4, 2022
…rtificate is not a puppet cert This duplicates the options on the client.post for get_auth_token() Without it the puppet agent successfully retrieves a token but cannot connect to Vault to retrieve a secret.
firstnevyn
force-pushed
the
fix_get_secret_options
branch
from
e4e7c53
to
8c0fce7
Compare
|
Squashed the rubocop commit and fix the spelling |
bastelfreak
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to support retrieving secrets from vault where the listener certificate is not a puppet cert
This duplicates the options on the client.post for get_auth_token()
Without it the puppet agent 6.28 successfully retrieves a token but cannot connect to Vault to retrieve a secret. it attempts to create a new tls connection with the puppet ssl context which fails.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues