Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undeploy_first parameter to wildfly_deployment #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexjfisher
Copy link
Member

Instead of using cli.update_deploy, when setting this parameter to
true, the deployment is undeployed, before being redeployed.

Instead of using `cli.update_deploy`, when setting this parameter to
`true`, the deployment is undeployed, before being redeployed.
@alexjfisher
Copy link
Member Author

TBH, I'm disappointed I couldn't figure out any way to avoid writing this change.

I played around with

operation-headers => { 'allow-resource-service-restart' => true }

but for some reason, when updating my ear, I'd still either have to manually undeploy it first, or restart the whole wildfly server.

@@ -54,6 +55,11 @@
end
end

newparam(:undeploy_first, :boolean => true, :parent => Puppet::Parameter::Boolean) do
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming things is hard! undeploy_first was the best I came up with. Open to suggestions. :)

@@ -39,7 +40,7 @@
end

newparam(:timeout) do
desc 'Operation timeout. Defaults to 120'
desc 'Operation timeout. Defaults to 300'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely unrelated, but now the desc matches the defaultto below.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 75.152% when pulling b9bda18 on alexjfisher:undeploy_first into d9433d4 on biemond:master.

@coveralls
Copy link

coveralls commented Oct 26, 2018

Coverage Status

Coverage increased (+0.8%) to 75.152% when pulling b9bda18 on alexjfisher:undeploy_first into d9433d4 on biemond:master.

@alexjfisher
Copy link
Member Author

Acceptance test failures appear unrelated.

An error occurred in a `before(:suite)` hook.
Failure/Error: on host, 'wget --header "Cookie: oraclelicense=accept-securebackup-cookie" -N -P /var/cache/wget http://download.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-linux-x64.tar.gz && tar -C /opt -zxvf /var/cache/wget/jdk-8u181-linux-x64.tar.gz'
Beaker::Host::CommandFailure:
  Host 'centos-7' exited with 8 running:
   wget --header "Cookie: oraclelicense=accept-securebackup-cookie" -N -P /var/cache/wget http://download.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-linux-x64.tar.gz && tar -C /opt -zxvf /var/cache/wget/jdk-8u181-linux-x64.tar.gz
  Last 10 lines of output were:
  	Location: https://edelivery.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-linux-x64.tar.gz [following]
  	--2018-10-26 15:44:21--  https://edelivery.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-linux-x64.tar.gz
  	Resolving edelivery.oracle.com (edelivery.oracle.com)... 172.226.81.72, 2600:1407:21:28c::2d3e, 2600:1407:21:2b2::2d3e
  	Connecting to edelivery.oracle.com (edelivery.oracle.com)|172.226.81.72|:443... connected.
  	HTTP request sent, awaiting response... 302 Moved Temporarily
  	Location: http://download.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-linux-x64.tar.gz?AuthParam=1540568781_40dbe13efa73e555850aca16f2749071 [following]
  	--2018-10-26 15:44:21--  http://download.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-linux-x64.tar.gz?AuthParam=1540568781_40dbe13efa73e555850aca16f2749071
  	Connecting to download.oracle.com (download.oracle.com)|23.195.64.167|:80... connected.
  	HTTP request sent, awaiting response... 404 Not Found
  	2018-10-26 15:44:23 ERROR 404: Not Found.

@alexjfisher alexjfisher closed this Nov 5, 2018
@alexjfisher alexjfisher reopened this Nov 5, 2018
@alexjfisher
Copy link
Member Author

@biemond Build is still failing due to an issue downloading Oracle java in the beaker tests. Is this something that you have to fix up on a regular basis?

@jairojunior jairojunior closed this Oct 1, 2019
@jairojunior jairojunior reopened this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants