module: allow to configure module user/group #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Motivation: for security reasons they shouldn't belong to the Wildfly user. Also, when installing Wildfly via RPM the current implementation fails on `mkdir -p`, as the `modules` directory belongs to root. I didn't want to change file ownership handling throughout the whole module. So this fix allows those who depend on RPMs and those who want to not grant the web server write access to it's binaries the possibility to achieve that goal.
Thomas-Gelf
force-pushed
the
feature/allow-to-configure-module-user
branch
from
0816712
to
e10346c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: for security reasons they shouldn't belong to the Wildfly user. Also,
when installing Wildfly via RPM the current implementation fails on
mkdir -p,as the
modulesdirectory belongs to root.I didn't want to change file ownership handling throughout the whole module. So
this fix allows those who depend on RPMs and those who want to not grant the web
server write access to it's binaries the possibility to achieve that goal.