Make the java_maxmetaspace_size param optional. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdeferme
force-pushed
the
maxmeta_optional
branch
from
9569ee4
to
a04588e
Compare
The default behaviour on most JVM versions is to have no limit for the Max Meta Space. While I understand wanting to set and limit it, in v3.0.0 this change is listed as an enhancement while actually being a breaking change. When one only reads the changelog without looking at the code, applications using more then the low default of 128MB will crash.
bdeferme
force-pushed
the
maxmeta_optional
branch
from
a04588e
to
5f52c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The default behaviour on most JVM versions is to have no limit for the Max Meta Space. While I understand wanting to set and limit it, in v3.0.0 this change is listed as an enhancement while actually being a breaking change.
When one only reads the changelog without looking at the code, applications using more then the low default of 128MB will crash.
This Pull Request (PR) fixes the following issues
n/a