Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall: Add missing sport for IPv6 with missing destination_addresses #105

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Firewall: Add missing sport for IPv6 with missing destination_addresses #105

merged 3 commits into from
Jan 1, 2024

Commits on Jan 1, 2024

  1. Ensure catalog compiles when endpoint is missing 

    Usually we parse the src port for incoming packets / the dst port for outgoing packets from the $endpoint param
The param is optional, in case you want to create a passive endpoint for clients with dynamic ip addresses
In those cases we still need to create firewall rules, but without src port for incoming packets / the dst port
To make this all a bit easier, we also added a new parameter, $endpoint_port, which takes precedence over parsing $endpoint.

Previously the catalog compilation failed with:
```
Evaluation Error: Left match operand must result in a String value. Got an Undef Value.
```

Because of: `if $endpoint =~  /:(\d+)$/ {`

This test verifies that the current code is broken.
    @bastelfreak
    bastelfreak committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    81c15bd View commit details
    Browse the repository at this point in the history

  2. Make src port for firwalling configureable 

    Usually we parse the src port for incoming packets / the dst port for outgoing packets from the $endpoint param The param is optional, in case you want to create a passive endpoint for clients with dynamic ip addresses In those cases we still need to create firewall rules, but without src port for incoming packets / the dst port To make this all a bit easier, we also added a new parameter, $endpoint_port, which takes precedence over parsing $endpoint.

Previously the catalog compilation failed with:
```
Evaluation Error: Left match operand must result in a String value. Got an Undef Value.
```

Because of: `if $endpoint =~  /:(\d+)$/ {`

#103 verifies that the
current code is broken.

Thew new code adds a safeguard to check if $endpoint is set. we also add
a new parameter in case we want to explicitly set the port.
    @bastelfreak
    bastelfreak committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    b0808de View commit details
    Browse the repository at this point in the history

  3. Firewall: Add missing sport for IPv6 with missing destination_addresses

    @bastelfreak
    bastelfreak committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    eb6c3bb View commit details
    Browse the repository at this point in the history