Use dnf or yum augeas path for main configuration #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the augeas path for main configuration is at `/files/etc/yum.conf/main`. On Fedora 36 and newer the hard coded augeas path does not exist: ``` [steve@fedora ~]$ augtool -e 'print /files/etc/yum.conf/main' augtool> print /files/etc/yum.conf/main ``` only the new updated dnf based path exists. ``` augtool> print /files/etc/dnf/dnf.conf /files/etc/dnf/dnf.conf /files/etc/dnf/dnf.conf/#comment = "see `man dnf.conf` for defaults and possible options" /files/etc/dnf/dnf.conf/main /files/etc/dnf/dnf.conf/main/gpgcheck = "True" /files/etc/dnf/dnf.conf/main/installonly_limit = "3" /files/etc/dnf/dnf.conf/main/clean_requirements_on_remove = "True" /files/etc/dnf/dnf.conf/main/best = "False" /files/etc/dnf/dnf.conf/main/skip_if_unavailable = "True" ``` Note on EL8 and EL9 both paths `/files/etc/yum.conf` and `/files/etc/dnf.conf` are valid and equal. Consequently on puppet runs `yum::init` sets the `installonly_limit` to 3 in the wrong non-existing file. To solve this create a new file yum::settings that can have values set from hiera for the `yum::config` type. The more obvious use of setting this in `init.pp` is not possible since including this in `yum::config` would be a huge change for the module. Note that when the install_limit is changed to 3 the following command is called `/usr/bin/package-cleanup --oldkernels --count=3 -y` which is invalid on at least EL9 and Fedora 36 and that should be independently fixed.
bastelfreak
approved these changes
May 15, 2023
Switch to checking versionlock in dnf location on EL8 and newer. EL8 is: ``` drwxr-xr-x. 3 root root 148 Apr 27 16:43 /etc/dnf/plugins lrwxrwxrwx. 1 root root 14 Oct 12 2022 /etc/yum/pluginconf.d -> ../dnf/plugins ```
|
merging red on Fedora but it must be red on fedora in master branch also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently the augeas path for main configuration is at
/files/etc/yum.conf/main.Use a dnf or yum based path based on the package_provider fact.
On Fedora 36 and newer that hard coded augeas path does not exist:
only the new updated dnf based path exists.
Note on EL8 and EL9 both paths
/files/etc/yum.confand/files/etc/dnf.confare valid and equal.Consequently on puppet runs
yum::initsets theinstallonly_limitto 3 in the wrong non-existing file.To solve this create a new file yum::settings that can have values set from hiera for the
yum::configtype. The more obvious use of setting this ininit.ppis not possible since including this inyum::configwould be a huge change for the module.Note that when the install_limit is changed to 3 the following command is called
/usr/bin/package-cleanup --oldkernels --count=3 -yand this is bug #295 . This patch hides that problem in acceptance tests again.