move zabbixapi gem installation into own class

REFERENCE.md

@@ -23,6 +23,7 @@
 * [`zabbix::server`](#zabbix--server): This will install and configure the zabbix-server deamon
 * [`zabbix::userparameter`](#zabbix--userparameter): This class can be used when you use hiera or The Foreman. With this tools you can't use and define. This make use of "create_resources".
 * [`zabbix::web`](#zabbix--web): This will install the zabbix-web package and install an virtual host.
+* [`zabbix::zabbixapi`](#zabbix--zabbixapi): This will install the zabbixapi gem.
 * [`zabbix::zapache`](#zabbix--zapache): This will install and configure the zapache monitoring script Upstream: https://github.com/lorf/zapache
 
 #### Private Classes
@@ -5427,6 +5428,33 @@ Whether we should manage SELinux rules.
 
 Default value: `$zabbix::params::manage_selinux`
 
+### <a name="zabbix--zabbixapi"></a>`zabbix::zabbixapi`
+
+This will install the zabbixapi gem.
+
+#### Parameters
+
+The following parameters are available in the `zabbix::zabbixapi` class:
+
+* [`zabbix_version`](#-zabbix--zabbixapi--zabbix_version)
+* [`puppetgem`](#-zabbix--zabbixapi--puppetgem)
+
+##### <a name="-zabbix--zabbixapi--zabbix_version"></a>`zabbix_version`
+
+Data type: `Any`
+
+This is the zabbix version.
+
+Default value: `$zabbix::params::zabbix_version`
+
+##### <a name="-zabbix--zabbixapi--puppetgem"></a>`puppetgem`
+
+Data type: `Any`
+
+Provider for the zabbixapi gem package.
+
+Default value: `$zabbix::params::puppetgem`
+
 ### <a name="zabbix--zapache"></a>`zabbix::zapache`
 
 This will install and configure the zapache monitoring script Upstream: https://github.com/lorf/zapache

manifests/web.pp

@@ -186,28 +186,15 @@
   # is set to false, you'll get warnings like this:
   # "Warning: You cannot collect without storeconfigs being set"
   if $manage_resources {
-    # Determine correct zabbixapi version.
-    case $zabbix_version {
-      /^[56]\.[024]/: {
-        $zabbixapi_version = '5.0.0-alpha1'
-      }
-      default: {
-        fail("Zabbix ${zabbix_version} is not supported!")
-      }
-    }
-
-    # Installing the zabbixapi gem package. We need this gem for
-    # communicating with the zabbix-api. This is way better then
-    # doing it ourself.
     file { $zabbix_template_dir:
       ensure => directory,
       owner  => 'zabbix',
       group  => 'zabbix',
       mode   => '0755',
     }
-    -> package { 'zabbixapi':
-      ensure   => $zabbixapi_version,
-      provider => $puppetgem,
+    -> class { 'zabbix::zabbixapi':
+      zabbix_version => $zabbix_version,
+      puppetgem      => $puppetgem,
     }
     -> class { 'zabbix::resources::web':
       zabbix_url     => $zabbix_url,

manifests/zabbixapi.pp

@@ -0,0 +1,34 @@
+# @summary This will install the zabbixapi gem.
+#
+# @param zabbix_version This is the zabbix version.
+# @param puppetgem Provider for the zabbixapi gem package.
+class zabbix::zabbixapi(
+  $zabbix_version = $zabbix::params::zabbix_version,
+  $puppetgem = $zabbix::params::puppetgem,
+) inherits zabbix::params {
+    # Determine correct zabbixapi version.
+    case $zabbix_version {
+      /^[56]\.[024]/: {
+        $zabbixapi_version = '5.0.0-alpha1'
+      }
+      default: {
+        fail("Zabbix ${zabbix_version} is not supported!")
+      }
+    }
+
+    $compile_packages = $facts['os']['family'] ? {
+      'RedHat' => [ 'make', 'gcc-c++', 'rubygems', 'ruby'],
+      'Debian' => [ 'make', 'g++', 'ruby-dev', 'ruby', 'pkg-config',],
+      default  => [],
+    }
+    ensure_packages($compile_packages)
+
+    # Installing the zabbixapi gem package. We need this gem for
+    # communicating with the zabbix-api. This is way better then
+    # doing it ourself.
+    package { 'zabbixapi':
+      ensure   => $zabbixapi_version,
+      provider => $puppetgem,
+    }
+
+}

spec/support/acceptance/prepare_host.rb

@@ -46,16 +46,4 @@ def prepare_host
 
   apply_manifest(cleanup_puppet)
   shell(cleanup_script)
-
-  install_deps = <<-SHELL
-      $compile_packages = $facts['os']['family'] ? {
-        'RedHat' => [ 'make', 'gcc-c++', 'rubygems', 'ruby'],
-        'Debian' => [ 'make', 'g++', 'ruby-dev', 'ruby', 'pkg-config',],
-        default  => [],
-      }
-      package { $compile_packages:
-        ensure => 'present',
-      }
-  SHELL
-  apply_manifest(install_deps)
 end