Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order problems with apt update #233

Closed
ITler opened this issue Jun 1, 2016 · 4 comments
Closed

Order problems with apt update #233

ITler opened this issue Jun 1, 2016 · 4 comments

Comments

@ITler
Copy link
Contributor

ITler commented Jun 1, 2016

Hy,

I use zabbix module together with other modules (puppetlabs official, modules from other people and organizations, my own).
Like yours, other modules also include vendor's package repository. Therefore the workflow usually is (for debian based nodes):

  1. define apt sources,
  2. then do apt-get update,
  3. then install module package(s), i.e. `package { 'zabbix-agent': }

Obviously in my setup this workflow works while composing all the different 3rd party modules, except the zabbix module :)

While tracking down my issues I've tried to work-around them, which was leading to ugly dependency cycles. I ended up with comparing your repo.pp with the one's from [postgresql] and [nginx] and recognized, that the mentioned workflow isn't implemented. As the zabbix module handles multiple package files (server, agent, ...) the approach used in postgresql module might be most convenient, as it works with explicit tagging.

Would you agree? PR needed

@bastelfreak
Copy link
Member

I don't quite understand the issue here. The module handles the zabbix.com repo and the package installation. Do you want to define the repo by yourself? Or is the update missing?

@ITler
Copy link
Contributor Author

ITler commented Jun 2, 2016

Jep, the update is missing. This raises when using zabbix module together with other modules. In my setup it happens, that zabbix agent is installed to early, before apt-update was executed. The PR #234 solves this.

@bastelfreak
Copy link
Member

thanks for the fix! merged and close.

@ITler
Copy link
Contributor Author

ITler commented Jun 2, 2016

thanks for accepting PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants