listenip in agent not resolving to IP address from network interface name

[glafir]

Hello!
A upgraded puppet-zabbix (v4.1.3 -> v6.3.0) then "listenip" in agent not resolv to address from networl face name.
In zabbix-agent config
ListenIP=enp0s18

But it is not IP-address. How I can resolve this problem?

[bastelfreak]

Hi @glafir, thanks for rising this issue. Can you provide the code you use to call this module? I assume you set explicitly set listenip?

The used regex doesn't match your network name:

puppet-zabbix/manifests/agent.pp

Line 298 in 3ac150d

/^(eth|lo|bond|lxc|eno|tap|tun|virbr).*/ => fact("networking.interfaces.${listen_ip}.ip"),

I think that's the issue.

[bastelfreak]

@glafir I proposed a fix in #494, could you test that?

[glafir]

Oh, Yes, yes!
I forget for this,
I change it in pre-versions.

so I did it

$listen_ip = $listenip ? {
/^(eth|lo|bond|ens|enp|lxc|eno|vmbr|tap|tun|virbr)./ => fact("networking.interfaces.${listen_ip}.ip"),
'' => undef,
default => $listenip,
}

But listenIP now is empty (((

[bastelfreak]

I updated my patch. There is currently a typo in the code. Can you test it again? Can you paste the code you use to call the zabbix::agent class?

[glafir]

It not working now. In zabbix-conf

+ListenIP=enp0s18

(((

[glafir]

But if I write in regex my inet-faces, I get empty $listenIP
For example

/^(eth|lo|bond|lxc|ens|enp|vmbr|eno|tap|tun|virbr).*/ => .....

[glafir]

Oh, Yes!
It is working now for me!

/^(eth|lo|bond|lxc|ens|enp|vmbr|eno|tap|tun|virbr).*/ => fact("networking.interfaces.${$listenip}.ip"),

Add please to repo! Thanks!

[glafir]

Full-code in listenip-section

  $listen_ip = $listenip ? {
    /^(eth|lo|bond|lxc|ens|enp|vmbr|eno|tap|tun|virbr).*/ => fact("networking.interfaces.${$listenip}.ip"),
    '*' => undef,
    default => $listenip,
  }

[bastelfreak]

We can do a new release as soon as #494 got reviewed and merged