Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Zabbix 5.0 #689

Closed
broadaxe opened this issue May 14, 2020 · 11 comments · Fixed by #730
Closed

Add Support for Zabbix 5.0 #689

broadaxe opened this issue May 14, 2020 · 11 comments · Fixed by #730

Comments

@broadaxe
Copy link

The current version of this module does not support Zabbix 5.0. I know this Zabbix version just got released a couple of days ago, but it would be awesome if/when it is supported. I understand this would take time.

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: Latest
  • Ruby: Latest with Puppet
  • Distribution: CentOS 7
  • Module version: Latest

How to reproduce (e.g Puppet code you use)

Use the current version of these Puppet library to deploy a Zabbix 5.0 server.

What are you seeing

Some of the packages have been renamed, so it fails to install the old names. In the end, the web based UI for Zabbix is broken.

What behaviour did you expect instead

I would guess I was to optimistic, I expected to have a working Zabbix server.

@VibroAxe
Copy link

I would also be keen to see this

@msnellen
Copy link

I'm also very interested in this as we are currently managing only our Zabbix-agent and would like to migrate to Zabbix 5 in the near future. Would be great if we could use this module to handle the whole thing.

@aclarkee
Copy link

I believe the main blocker here will be that the ZabbixAPI rubygem only officially supports up to 4.2, and hasn't had any update since November 2019

I wonder where that leaves this module, since it relies heavily on this rubygem.. Either branching off and maintaining a new version of the gem, or talking to the API directly?..

@jameskirsop
Copy link
Contributor

At this point, I'm probably going to have to abandon using this module because of the need to move to 5.0 rapidly.

I'm not using the features of this module that require the ZabbixAPI rubygem - and if this is a roadblock to getting 5.0 support, I'd be all for removing support for automatically adding hosts with agents via the API.

@aclarkee
Copy link

aclarkee commented Jun 3, 2020

I've actually been doing some testing with zabbix 5.0 - the zabbixapi gem works fine, just warns - so seems like my suspicion above was misplaced.

I'll submit a pull request a bit later, but my usecase is very specific, so not everything is tested. Someone else will have to step up and contribute code to get their usecases working :)

@jameskirsop
Copy link
Contributor

@aclarkee Do you have a branch for your changes that I can take a look at and test with (and possibly contribute to)?

@aclarkee
Copy link

aclarkee commented Sep 11, 2020

@jameskirsop Sorry for the late reply, got sidetracked with other priorities. I've just submitted a couple of pull requests with my modifications.

I manage the repo & webserver config outside this module - and am using aws RDS for the postgresql DB, so have zabbix::web::manage_repo & zabbix::web::manage_vhost set to false in heira and don't use the zabbix::database class. (I'm currently passing DB info straight through to zabbix::server & zabbix::web)

(I'm running off master with my changes + #700 & #623)

@LarsErikP
Copy link

For what it's worth, I'll "+1" whis. Would love to see Zabbix 5 support, as we're planning to deploy Zabbix in our environment. Would be nice to be able to use the latest version :-)

@igalic
Copy link
Contributor

igalic commented Sep 19, 2020

is anyone here able to provide a patch for 5.x support?
is anyone's company here willing to "sponsor" a patch?
(that is, give you the time to work on this)

@jameskirsop
Copy link
Contributor

jameskirsop commented Jan 20, 2021

@bastelfreak, could we release/tag the updated version of the module so the 5.0 improvements can be deployed??

Also - I've just tried to deploy the latest master to a clean server and the Zabbix Frontend repo isn't configured as described here.

It seems like we need to move to installing the Zabbix repo config from the new(?) package that includes the updated Zabbix-frontend repo.

Would recommend we reopen this until 5.0 is fully supported.

@pkaroluk
Copy link

You can take latest PHP using SCL module so it doesn't seem difficult to implement

  scl::collection {
    [
      'httpd24',
      'rh-php73',
    ]:
    ensure => present,
    enable => true,
    before => Class['apache'],
  }

  Package {
    [
      'httpd24-mod_ssl',
      'rh-php73-php-mysqlnd',
      'rh-php73-php-gd',
      'rh-php73-php-bcmath',
      'rh-php73-php-mbstring',
      'rh-php73-php-xml',
      'rh-php73-php-json',
      'rh-php73-php-ldap',
    ]:
    ensure => present,
    before => Class['apache'],
  }

  class { '::apache::version':
    scl_httpd_version => '2.4',
    scl_php_version => '7.3',
  }
  -> class { '::apache::mod::prefork':
    startservers => '8';
  }
  -> class { '::apache::mod::php': }

(*) I haven't tested it yet with 5.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants