Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zabbixapi version to 4.2.0 #730

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Bump zabbixapi version to 4.2.0 #730

merged 3 commits into from
Jan 18, 2021

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Dec 7, 2020

Pull Request (PR) description

This is a re-submission of #623, because the original PR was probably abandoned.

This Pull Request (PR) fixes the following issues

Fixes #621 (Zabbix 4.2 support)
Fixes #544 (Zabbix 3.4 support)
Fixes #689 (Zabbix 5.0 support; partially, should be considered the first step)

@fraenki fraenki changed the title bump zabbix version bump zabbixapi version Dec 7, 2020
@fraenki fraenki changed the title bump zabbixapi version Bump zabbixapi version Dec 7, 2020
@fraenki
Copy link
Member Author

fraenki commented Jan 17, 2021

@kenyon I've fixed the failing acceptance tests. Please merge :)

FWIW, Travis CI still reports a failure, but it's unrelated to my changes:

"error":"toomanyrequests: You have reached your pull rate limit. 
You may increase the limit by authenticating and upgrading: 
https://www.docker.com/increase-rate-limit"

ci

@kenyon kenyon removed the tests-fail label Jan 17, 2021
@kenyon
Copy link
Member

kenyon commented Jan 17, 2021

I reran the failed test, and it passed.

@bastelfreak
Copy link
Member

thanks for the PR! I will do some updates to the others we've open and try to merge this one later today

@bastelfreak
Copy link
Member

@bastelfreak bastelfreak merged commit c3d6951 into voxpupuli:master Jan 18, 2021
@bastelfreak bastelfreak changed the title Bump zabbixapi version Bump zabbixapi version to 4.2.0 Jan 18, 2021
@fraenki
Copy link
Member Author

fraenki commented Jan 18, 2021

@bastelfreak Thank you! I think it's safe to close #623 too (it is the abandoned PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Zabbix 5.0 Zabbix 4.2 Support API Error
3 participants