Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass manage_repo and zabbix_repo to repo.pp and prevent double include #110

Merged
merged 2 commits into from Jul 23, 2015

Conversation

@mmerfort
Copy link

mmerfort commented Jul 21, 2015

All classes which call zabbix::repo should pass manage_repo and zabbix_version to zabbix::repo.
To prevent double includes the classes will check if zabbix::repo has already been included.
Instead of checking if the zabbix::repo class should be included (if $manage_repo) the class will be included either way and zabbix::repo will decide if it manages the repositories.

Martin Merfort added 2 commits Jul 20, 2015
zabbix::repo always used the default when called from zabbix::server.

* Add manage_repo to parameters of zabbix::server
* Add manage_repo to parameters passed to zabbix::server in init.pp
* Add documentation for parameter in server.pp
* Add defined check to all classes which include repo
* If it is defined always include it and let the class itself check if
  it should manage the repo
dj-wasabi added a commit that referenced this pull request Jul 23, 2015
Pass manage_repo and zabbix_repo to repo.pp and prevent double include
@dj-wasabi dj-wasabi merged commit 8863bbe into voxpupuli:master Jul 23, 2015
@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

dj-wasabi commented Jul 23, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.