Adjust server config and databases sqls for 3.0 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I guess it's a big topic, most of the tests fail. |
|
Hi @slashr00t , Thank you for making time to create this PR, but I can't accept PR that fails the CI tests. |
|
Hi @dj-wasabi , I've fixed the code and it passed all the tests. I've also added a simple comment regarding this sqls placement difference. |
dj-wasabi
added a commit
that referenced
this pull request
Feb 16, 2016
Adjust server config and databases sqls for 3.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've prepared a fix for version 3.0. It looks like guys from Zabbix have changed package structure with sqls - now there's only a single file in an upper directory.
I also needed to adjust server config template. Maybe it's not the most elegant solution, but it works.