Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop #204

Merged
merged 150 commits into from
Apr 17, 2016
Merged

Update rubocop #204

merged 150 commits into from
Apr 17, 2016

Conversation

bastelfreak
Copy link
Member

  • remove trailing whitespace

Enabled:

  • Style/HashSyntax
  • Style/DefWithParentheses

@bastelfreak bastelfreak changed the title Update rubocop [WIP]Update rubocop Apr 11, 2016
@bastelfreak
Copy link
Member Author

hey. Do we want to keep enabled cops in the .rubocop.yml or should I remove them?

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
Copy link
Member Author

@dj-wasabi what do you think so far, are there any cops that you would like to keep disabled? I think there are ~25 left which I will deal with tomorrow.

I did one commit per cop, which makes reverting them easier if any of them introduces a regression.

@dj-wasabi
Copy link
Contributor

Hi @bastelfreak

This looks very very good. If you could fix the conflicts I'll be very happy to merge this request. :-) 👍

@bastelfreak
Copy link
Member Author

Rubocop doesn't always find all issues related to one cop. It found a few old issues after the rebase. will fix that in a few.

@bastelfreak
Copy link
Member Author

I'm ready for merge if this turns green.

@bastelfreak bastelfreak changed the title [WIP]Update rubocop Update rubocop Apr 17, 2016
@dj-wasabi dj-wasabi merged commit 18ee20b into voxpupuli:master Apr 17, 2016
@dj-wasabi
Copy link
Contributor

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants