Fix216 #217
Fix216 #217
Conversation
this addresses voxpupuli#216 getvar() comes from stdlib, scope.lookupvar is a dirty erb hack.
this is the frist release where getvar() works with strict variables https://forge.puppet.com/puppetlabs/stdlib/changelog#2014-11-10---supported-release-440
rubocop 0.39.0 recommended it. 0.40.0 doesnt ¯\_(ツ)_/¯
this doesn't make any sence here. We're creating a new subclass and don't want to redeclare puppet.
| @@ -265,8 +265,7 @@ | |||
| # is set to for example "eth1" or "bond0.73". | |||
| if ($listenip != undef) { | |||
There was a problem hiding this comment.
this whole thing could be turned into a case statement to a little clearer
There was a problem hiding this comment.
but lets leave that for another time maybe?
There was a problem hiding this comment.
yep. referenced in another issue.
| @@ -117,7 +116,8 @@ def package_provider_for_gems | |||
| database_name: 'zabbix-server', | |||
| database_user: 'zabbix-server', | |||
| database_password: 'zabbix-server', | |||
| zabbix_server: 'localhost') | |||
| zabbix_server: 'localhost', | |||
There was a problem hiding this comment.
sigh, of course that now causes a build failure _
There was a problem hiding this comment.
Try
let :params do
super().merge({
# stuff
})
Pass the hash! You can do a trailing comma this way because it's a hash, not an argument to a method.
There was a problem hiding this comment.
this will throw:
spec/classes/database_mysql_spec.rb:11:21: C: Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
facts.merge({ ...the rubocop config in this module is a bit stricter than our default one, and I want to keep that behavior. I will remove the commit as @jyaworski also seems to be fine with that.
|
@igalic IMO I should revert the last commit, then we can merge it. Opinions? |
|
Sounds good to me. |
can somebody review? This should fix #216