Allows setting ListenIP as "lo" loopback interface. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
felipe1982
commented
May 27, 2016
felipe1982
commented
- listenip => 'eth0' was being ignored in zabbix-agentd.conf because $listen_ip was not being set when regex matched. now
$listen_ip will be set to the IPaddress returned from $ ::ipaddress_eth0 - added option to use interface "lo" (127.0.0.1)
* listenip => 'eth0' was being ignored in zabbix-agentd.conf because $listen_ip was not being set when regex matched. now $listen_ip will be set to the IPaddress returned from $::ipaddress_eth0 * added option to use interface "lo" (127.0.0.1)
| $int_name = getvar("::ipaddress_${listenip}") | ||
| $listen_ip = $int_name |
There was a problem hiding this comment.
You could just set $listen_ip directly, here.
There was a problem hiding this comment.
Are you suggesting not using $int_name, and replacing it with:
$listen_ip = getvar("::ipaddress_${listenip}") ? If $int_name is not used, then go for it. I didn't want to break the module by removing a variable I didn't understand.
There was a problem hiding this comment.
Yes. It's not used anywhere else.
|
Could you also make the same change here? puppet-zabbix/manifests/proxy.pp Line 424 in f58bdb0 |
|
@jyaworski I hope I did it correctly :) I'm new to github. And I am only using Web UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.