Replaced agent systemd service with official #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Dec 1, 2016
|
|
||
| [Service] | ||
| EnvironmentFile=-/etc/sysconfig/zabbix-agent |
There was a problem hiding this comment.
this is redhat specific, but we use the unit file also on other systems:
https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/startup.pp#L52
There was a problem hiding this comment.
@bastelfreak Removed this line. Anyway there is no /etc/sysconfig/zabbix-agent file even on redhat.
BcTpe4HbIu
force-pushed
the
320-systemd-agent-service
branch
from
fa6cecd
to
45a3a5a
Compare
bastelfreak
reviewed
Dec 7, 2016
| PIDFile=<%= @pidfile %> | ||
| PrivateTmp=yes | ||
| ProtectSystem=full | ||
| ProtectHome=yes |
There was a problem hiding this comment.
so these additional security settings are pretty smart, but not upstream, I would prefer if we keep them or at least open up a ticket upstream to mention these.
There was a problem hiding this comment.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #320