Using $manage_service in zabbix::proxy #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Apr 3, 2017
manifests/proxy.pp
Outdated
| Package["zabbix-proxy-${db}"], | ||
| File[$include_dir], | ||
| File[$proxy_configfile_path]], | ||
| if $manage_service == true { |
There was a problem hiding this comment.
this should be enough:
if $manage_service {
|
Thanks for the PR @Samgarr. Are you able to also add spec tests for this change? |
|
I'm not sure right now, Ruby is new for me, spec tests also. |
|
Don't worry. Feel free to join our IRC channel #voxpupuli on freenode. We're happy to help you with the tests. |
Samgarr
force-pushed
the
manage_proxy_service
branch
from
56207eb
to
8a9ee67
Compare
bastelfreak
reviewed
Dec 18, 2017
manifests/proxy.pp
Outdated
| zabbix_proxy => $zabbix_proxy, | ||
| zabbix_proxy_ip => $zabbix_proxy_ip, | ||
| before => [ | ||
| Service[$proxy_service_name], |
There was a problem hiding this comment.
is this the only different line? We shouldt do code duplication here. Please write Service[$proxy_service_name] into a variable and use that in the before parameter.
Signed-off-by: Samgarr <honza@pechek.cz>
Samgarr
force-pushed
the
manage_proxy_service
branch
from
ce9ae8a
to
37e7173
Compare
|
Rebased, spec tests added. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allowing use of $manage_service in zabbix::proxy class.