Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Zabbix 3.4 #436

Merged
merged 1 commit into from
Sep 17, 2017
Merged

Fix for Zabbix 3.4 #436

merged 1 commit into from
Sep 17, 2017

Conversation

Menollo
Copy link
Contributor

@Menollo Menollo commented Aug 22, 2017

The SenderFrequency variable does not exist anymore in zabbix 3.4.

@bastelfreak
Copy link
Member

Hi @Menollo, thanks for the PR. Can you take a look at the failling spec tests?

@Heidistein
Copy link
Contributor

The failing tests are, as far as I understand, unrelated. Also older PR's suffer from this.
The failure is in:
Zabbix::Resources::Userparameters[foo_Zabbix_Proxy]

 Failure/Error: it { is_expected.to contain_zabbix__resources__userparameters('foo_Zabbix_Proxy') }

   expected that the catalogue would contain Zabbix::Resources::Userparameters[foo_Zabbix_Proxy]

 # ./spec/classes/proxy_spec.rb:109:in `block (5 levels) in <top (required)>'

The SenderFrequency variable does not exist anymore in zabbix 3.4.
@bastelfreak
Copy link
Member

We fixed this in master. I rebased the branch. It should turn green now on travis.

@bastelfreak bastelfreak merged commit 125adcf into voxpupuli:master Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests-fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants