Add missing proxy_mode variable to zabbix_proxy provider #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 21, 2017
| @@ -10,6 +10,10 @@ def create | |||
| # Set some vars | |||
| host = @resource[:hostname] | |||
| ipaddress = @resource[:ipaddress] | |||
|
|
|||
| # Normally 0 is active and 1 is passive, in the API, its 5 and 6 | |||
| proxy_mode = @resource[:mode] + 5 | |||
There was a problem hiding this comment.
Why the +5? And does this work because the puppet code passes in a string while the type doesn't munge it to an integer.
There was a problem hiding this comment.
The comment explains it. I am not sure why, but in the api documentation active proxy is 5 and passive is 6 where in the config it's 0 and 1. So to make it work I simply add 5 to the value.
It works for me, this is in my production Puppet server.
|
Hi @Breaker1, thanks for the PR. Can you check your mail address here as well? |
|
I have added the email address used to my account. |
bastelfreak
changed the title
|
Thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #334
I found a couple issues with the zabbix_proxy ruby code used for managing the proxy resources on the zabbix server. I think this is fixed in a proper way. I am not a Ruby developer, but it has fixed the issues I was experiencing with my manifests.