#476 Pass credentials for HTTP auth #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the usual Zabbix user and password, the credentials are now passed on to the Zabbix api client for HTTP basic auth support.
|
There is one test failing and it seems to be related to Travis and/or beaker. |
|
restarted the failed job |
|
Fixes #476 |
bastelfreak
reviewed
Jan 29, 2018
| @@ -11,7 +11,9 @@ def self.create_connection(zabbix_url, zabbix_user, zabbix_pass, apache_use_ssl) | |||
| zbx = ZabbixApi.connect( | |||
| url: "#{protocol}://#{zabbix_url}/api_jsonrpc.php", | |||
| user: zabbix_user, | |||
| password: zabbix_pass | |||
| password: zabbix_pass, | |||
| http_user: zabbix_user, | |||
There was a problem hiding this comment.
what happens when those variables are empty?
There was a problem hiding this comment.
They never are empty since they re use the same regular Zabbix API credentials.
And in a setup without HTTP auth, the HTTP Auth header is just ignored by Apache.
There was a problem hiding this comment.
okay, thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the usual Zabbix user and password, the credentials are now passed on to the Zabbix api client for HTTP basic auth support.