Fixed versioncmp compare and fixed typo in file zabbix-server-ips.te #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabian1976
referenced
this pull request
Jan 23, 2018
alexjfisher
approved these changes
Jan 28, 2018
|
@Fabian1976 Does this now fix the original issue? |
|
It did fix the issue. It now properly applied the selinux parameters and the zabbix-server starts properly |
|
@Fabian1976 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioncmp in server.pp to check if it is 3.3 or greater, doesn't work. versioncmp can't return a value greater then 1. It should be greater then 0 (see: versioncmp docs)
And if the versioncmp did work, it couldn't have loaded the correct .te file. It has a typo in it. The file is named zabbix-server-ipc.te and not zabbix-server-ips.te.
So this code looks like it never runned on anyone's server.