Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify dependency for database handling #508

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Clarify dependency for database handling #508

merged 1 commit into from
Jun 21, 2018

Conversation

stefanandres
Copy link
Contributor

See #505

@bastelfreak bastelfreak mentioned this pull request Jun 20, 2018
@bastelfreak bastelfreak added the bug Something isn't working label Jun 20, 2018
@bastelfreak
Copy link
Member

Thanks for the bugfix @stefanandres !

@bastelfreak
Copy link
Member

@stefanandres can you take a look at the travis failures?

@stefanandres
Copy link
Contributor Author

Yes, of course :-)

@stefanandres
Copy link
Contributor Author

stefanandres commented Jun 21, 2018

Ah, in fact I was using it wrong.

The workflow should be:
Use the following classes (in this Order):

  • zabbix::database
  • mysql::server
  • zabbix::server

Before I was using zabbix::database::mysql directly, but server.pp already requires on the package. To what is to be done is to make zabbix::database::mysql a private class. I'll adjust the PR for this.
This will help new users not to confuse it also.

This class should only be called by zabbix::server or zabbix::proxy
for proper dependency handling.
@stefanandres stefanandres changed the title Add missing dependency for sql files on their Package Clarify dependency for database handling Jun 21, 2018
@bastelfreak
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants