-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing enable => true for zabbix-java-gateway #516
Add missing enable => true for zabbix-java-gateway #516
Conversation
d76f6eb
to
56a9138
Compare
thansk for the fix @stefanandres. Can you take a look at the failing travis jobs? |
56a9138
to
28cc459
Compare
Of course, it seems I've added and extra |
Oh, this is the same Bug I fixed a few months ago: https://github.com/voxpupuli/puppet-zabbix/pull/516/files#diff-937db54f48c43542eecbbe379d023313R94 prevents this PR to work. I'll rewrite this bit today/tomorrow like I did in proxy.pp |
232e43f
to
c829447
Compare
@bastelfreak Somehow the redhat/centos-5 line troubles the CI, can we remove support this kind of old OS?
|
@stefanandres that is indeed legacy. We don't support centos 5 anymore. You can purge the block if you want. |
b5f603a
to
3686348
Compare
Hm, do you understand the current travis error?
It's not like I touched any of this stuff. :-) |
2462f94
to
168b761
Compare
@stefanandres there is currently an issue with one of our dependencies. Please rebase after #518 got merged. |
Remove obsolete redhat-5 code.
168b761
to
5281477
Compare
I've rebased against the current master and now the tests are all successfull |
Thanks @stefanandres ! |
The zabbix-java-gateways service should be enabled