Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing enable => true for zabbix-java-gateway #516

Merged

Conversation

stefanandres
Copy link
Contributor

The zabbix-java-gateways service should be enabled

@stefanandres stefanandres force-pushed the fix-javagateway-service-enable branch from d76f6eb to 56a9138 Compare July 16, 2018 08:54
@bastelfreak bastelfreak added the bug Something isn't working label Jul 16, 2018
@bastelfreak
Copy link
Member

thansk for the fix @stefanandres. Can you take a look at the failing travis jobs?

@stefanandres
Copy link
Contributor Author

Of course, it seems I've added and extra end - tests should run with success now.

@stefanandres
Copy link
Contributor Author

Oh, this is the same Bug I fixed a few months ago:

https://github.com/voxpupuli/puppet-zabbix/pull/516/files#diff-937db54f48c43542eecbbe379d023313R94 prevents this PR to work. I'll rewrite this bit today/tomorrow like I did in proxy.pp

@stefanandres stefanandres force-pushed the fix-javagateway-service-enable branch 2 times, most recently from 232e43f to c829447 Compare July 16, 2018 14:06
@stefanandres
Copy link
Contributor Author

stefanandres commented Jul 17, 2018

@bastelfreak Somehow the redhat/centos-5 line troubles the CI, can we remove support this kind of old OS?

  # Workaround for: The redhat provider can not handle attribute enable
  # This is only happening when using an redhat family version 5.x.
  if $::osfamily == 'redhat' and $::operatingsystemrelease =~ /^5.*/ {
    $enable = undef
  }  else {
    $enable = true
  }

@bastelfreak
Copy link
Member

@stefanandres that is indeed legacy. We don't support centos 5 anymore. You can purge the block if you want.

@stefanandres stefanandres force-pushed the fix-javagateway-service-enable branch 2 times, most recently from b5f603a to 3686348 Compare July 18, 2018 07:52
@stefanandres
Copy link
Contributor Author

Hm, do you understand the current travis error?
https://travis-ci.org/voxpupuli/puppet-zabbix/jobs/405240150 =>

12 processes for 16 specs, ~ 1 specs per process
/home/travis/.rvm/gems/ruby-2.1.9/bin/bundle:23:in `load': cannot load such file -- /home/travis/.rvm/rubies/ruby-2.1.9/lib/ruby/gems/2.1.0/gems/bundler-1.16.3/exe/bundle (LoadError)
	from /home/travis/.rvm/gems/ruby-2.1.9/bin/bundle:23:in `<main>'
	from /home/travis/.rvm/gems/ruby-2.1.9/bin/ruby_executable_hooks:24:in `eval'
	from /home/travis/.rvm/gems/ruby-2.1.9/bin/ruby_executable_hooks:24:in `<main>'
/home/travis/.rvm/gems/ruby-2.1.9/bin/bundle:23:in `load': cannot load such file -- /home/travis/.rvm/rubies/ruby-2.1.9/lib/ruby/gems/2.1.0/gems/bundler-1.16.3/exe/bundle (LoadError)
	from /home/travis/.rvm/gems/ruby-2.1.9/bin/bundle:23:in `<main>'
	from /home/travis/.rvm/gems/ruby-2.1.9/bin/ruby_executable_hooks:24:in `eval'
	from /home/travis/.rvm/gems/ruby-2.1.9/bin/ruby_executable_hooks:24:in `<main>'
/home/travis/.rvm/gems/ruby-2.1.9/bin/bundle:23:in `load': cannot load such file -- /home/travis/.rvm/rubies/ruby-2.1.9/lib/ruby/gems/2.1.0/gems/bundler-1.16.3/exe/bundle (LoadError)

It's not like I touched any of this stuff. :-)

@stefanandres stefanandres force-pushed the fix-javagateway-service-enable branch 2 times, most recently from 2462f94 to 168b761 Compare July 19, 2018 07:35
@bastelfreak
Copy link
Member

@stefanandres there is currently an issue with one of our dependencies. Please rebase after #518 got merged.

Remove obsolete redhat-5 code.
@stefanandres stefanandres force-pushed the fix-javagateway-service-enable branch from 168b761 to 5281477 Compare July 30, 2018 11:07
@stefanandres
Copy link
Contributor Author

stefanandres commented Jul 30, 2018

I've rebased against the current master and now the tests are all successfull

@bastelfreak
Copy link
Member

Thanks @stefanandres !

@bastelfreak bastelfreak merged commit b6aad58 into voxpupuli:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants