Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gentoo support #535

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Add Gentoo support #535

merged 1 commit into from
Sep 24, 2018

Conversation

lordievader
Copy link
Contributor

The agent service name is now defined in the params.pp as well since it is different on Gentoo.

Pull Request (PR) description

It introduces variables for Gentoo. Additionally it replaces the hardcoded agent service name with one from params.pp (which is also OS dependend).
This PR does not fix the repo not bein supported on Gentoo warning. However, the agent can be used without managing the repo as well.

This Pull Request (PR) fixes the following issues

Fixes #531

@lordievader
Copy link
Contributor Author

Oh, I have not had the chance to test it with Beaker. If this is necesarry I'll set it up again, but in all honesty I rather not ;)

@bastelfreak
Copy link
Member

Hey @lordievader, thanks for the PR. Do you think you can contribute (at least facter2.5) facts from a gentoo instance to https://github.com/camptocamp/facterdb/tree/master/facts/2.5 ? Beaker-docker currently has no support for gentoo, so we need to stick with the unit tests. Please add Gentoo to the metadata.json. Afterwards our testsetup will check facterdb for mocked gentoo facts and execute the tests against it.

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Sep 10, 2018
@bastelfreak
Copy link
Member

Just if you're interested: You could contribute gentoo compatibility to https://github.com/puppetlabs/beaker-puppet. I am happy to help if you're interested. You can reach the Vox Pupuli people almost 24/7 in #voxpupuli on the freenode IRC network or on https://puppetcommunity.slack.com

@baurmatt
Copy link
Contributor

baurmatt commented Sep 17, 2018

Failing tests due to https://tickets.puppetlabs.com/browse/MODULES-7802

Edit: We're also interested in this PR! @bastelfreak Do you think it's really necessary to add Gentoo facts to facterdb, wait for the facterdb release and add spec tests? Although I support the Gentoo support of facterdb, this seems like a little bit to much overhead

@bastelfreak
Copy link
Member

the facterdb update isn't required, but it would be very very helpful.

@lordievader
Copy link
Contributor Author

I suppose my lazyness payed off. Thanks @baurmatt 🗡️
@bastelfreak Is this enough to get this merged into master?

I'd still want to contribute to beaker-puppet, just haven't had time to setup a proper beaker environment yet.

@bastelfreak bastelfreak changed the title Add Gentoo variables, fixes #531 Add Gentoo support Sep 23, 2018
@bastelfreak
Copy link
Member

Hi @lordievader, can you add Gentoo to the metadata.json? Afterwards we can merge this.

The agent service name is now defined in the params.pp as well.
Add Gentoo without version to metadata.json.
@lordievader
Copy link
Contributor Author

Hi @bastelfreak, Gentoo has been added to metadata.json. The PR has been rebased on the current master and everything has been squashed into one commit.

@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Sep 24, 2018
@bastelfreak
Copy link
Member

Thanks!

@bastelfreak bastelfreak merged commit 88943d1 into voxpupuli:master Sep 24, 2018
@lordievader lordievader deleted the lordievader_gentoo_fix branch October 15, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the puppet-zabbix module on Gentoo gives an ExecutionFailure
3 participants