Put selboolean{'zabbix_can_network'} inside ensure_resources

[KrzysztofHajdamowicz]

Pull Request (PR) description

puppet-zabbix module depends on stdlib, ensure_resources is already availble for usage.
My motivation for this change is global declaration that zabbix_can_network and zabbix server belongs to this global declaration.
ensure_resource allows for resource duplication as long as declaration of those resource is identical.
Also, notifying service dependency is useless IMO, as SELinux and ZBX are separate things and ZBX doesn't need to be restarted in order to make SELinux policies to be applied.

This Pull Request (PR) fixes the following issues

Fixes #598

[bastelfreak]

Hi. Can you please expain why you wrap the selboolean into ensure_resource()? The zabbix_can_network setting is pretty specific to selinux so in my opinion should be managed within this module.

[KrzysztofHajdamowicz]

Hi. Can you please expain why you wrap the selboolean into ensure_resource()? The zabbix_can_network setting is pretty specific to selinux so in my opinion should be managed within this module.

zabbix_can_network seboolean allows both zabbix-agent and zabbix-server to create TCP connections.
In our usecase we want do check did zbxagnt can connect to specified TCP port (service stops listening at it, despite it is still running so systemd can't complain). Such service exists on all hosts, including Zabbix Server, thus duplicate resource declaration.

ensure_resource looks like good solution, because, according to documentation

If the resource already exists, but does not match the specified parameters, this function attempts to recreate the resource, leading to a duplicate resource definition error

So puppet will run with success ONLY IF all declarations are the same. Thus, no difference if it resource is managed by puppet-zabbix or elsewhere. This resource can be only in state puppet-zabbix wants or puppet run will fail.

[KrzysztofHajdamowicz]

Also, can You retrigger unit test? All failed ones are due to timeout od VM with docker.

[bastelfreak]

I restarted all failed jobs.

[KrzysztofHajdamowicz]

Looks like unittests are OK :)