Implement self.prefetch for zabbix_proxy #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
force-pushed
the
self.prefetch/zabbix_proxy
branch
2 times, most recently
from
c3fd5b7
to
0f8621d
Compare
|
The tests which failed did this because of: Pretty sure that this isn't a problem of this change ;) |
|
@baurmatt And not because https://github.com/voxpupuli/puppet-zabbix/pull/642/files#diff-677c6e628f74bf4e5fe32149fb37a725R29 printed a crazy amount of stuff to stdout? |
baurmatt
force-pushed
the
self.prefetch/zabbix_proxy
branch
2 times, most recently
from
8d3df0c
to
04e8d54
Compare
|
@alexjfisher LOL (literally) :D Good catch, thanks! :) I've updated the code. But there still two failing tests. As those are also failing in the master, I guess I'm good here. |
|
Tests will be fixed with #646. |
This is another change for voxpupuli#570.
baurmatt
force-pushed
the
self.prefetch/zabbix_proxy
branch
from
04e8d54
to
aa4704c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The template parameter got removed because it had no function and just added additional API calls. I therefore labeled this PR
backwards-incompatible.This Pull Request (PR) fixes the following issues
This is another change for #570.