Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zabbix.com repository for Raspbian Linux #648

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Add zabbix.com repository for Raspbian Linux #648

merged 2 commits into from
Feb 1, 2020

Conversation

emetriqChris
Copy link
Contributor

@emetriqChris emetriqChris commented Jan 10, 2020

Zabbix.com provides a repository for Raspbian Linux under http://repo.zabbix.com/zabbix//raspbian/

The puppet-zabbix module uses the fact os.name for determining the URL of the used repository which is "Debian" for Raspbian Linux. The Debian repositiry is not providing "armhf" deb packages so the installation of zabbix fails.

This patch is an if condition which sets the variable $operatingsystem to 'raspbian' if the fact os.distro.id is 'Raspbian'. Otherwise the behaviour is not modified.

This way puppet-zabbix is choosing the right repository for installing zabbix on a Raspbian Linux.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

….zabbix.com/zabbix/<version>/raspbian/

The puppet-zabbix module uses the fact os.name for determining the URL of the used repository which is "Debian" for Raspbian Linux. The Debian repositiry is not providing "armhf" deb packages so the installation of zabbix fails.

This patch is an if condition which sets the variable $operatingsystem to 'raspbian' if the fact os.distro.id is 'Raspbian'. Otherwise the behaviour is not modified.
@bastelfreak
Copy link
Member

thanks for the PR @emetriqChris. Can you please add Raspbian to the metadata.json?

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Jan 15, 2020
@emetriqChris
Copy link
Contributor Author

Hi,

thanks for looking into this. I added Raspbian to metadata.json but somehow Travis crashed. It looks like the test couldn't login to the docker container. Maybe re-running could help.

Greetings,
Chris

@bastelfreak
Copy link
Member

I restarted the failed job

@bastelfreak bastelfreak merged commit 0247089 into voxpupuli:master Feb 1, 2020
@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Feb 1, 2020
@bastelfreak bastelfreak changed the title zabbix.com repository for Raspbian Linux Add zabbix.com repository for Raspbian Linux Feb 1, 2020
@emetriqChris
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants