-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MSI package install on Windows #790
Conversation
f8ca238
to
cf07ee3
Compare
Hey @spicyprogramming ! Thank for the PR! |
3aa6e7c
to
b60ac30
Compare
Could you give me some guidance @root-expert ? I've never done anything like this for puppet. Thanks |
hey @spicyprogramming , thanks for the PR. Can you add the windows versions this is supposed to work on to the metadata.json? |
@bastelfreak AFAIK this should work on "Any" version, according to the official website: |
Will look into test failures later today |
b60ac30
to
df9cf00
Compare
the CI errors are fixed on master. can you rebase against our latest master branch? (please don't create a merge commit) |
e457f33
to
d5cf9ef
Compare
/ping Is there anything else left to do to move this forward? |
We need some unit tests. Take a look here on how to write them properly. If you need help you can join on channel #voxpupuli at Libera.Chat or at the Puppet Community Slack. 😄 |
d5a5522
to
6dfbe5e
Compare
6dfbe5e
to
3f2788e
Compare
@spicyprogramming Seems your commit email is not associated with your Github account, could fix that before we merge this PR? |
3f2788e
to
682133e
Compare
682133e
to
a73fd1b
Compare
@root-expert fixed. Thanks for helping me out push this through, by the way. |
Pull Request (PR) description
This change would allow Zabbix agent deployments on systems with no internet access (air gapped networks or or otherwise blocked)
Sample usage:
This Pull Request (PR) fixes the following issues
This is a new feature