Default denykey to undef #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails because of missing quotes here? |
|
It fails on |
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
bastelfreak
force-pushed
the
denykey-fix
branch
from
11f6a9c
to
f4e927e
Compare
|
I will fix the arch linux failures in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Having a default value makes it impossible to undef the parameter, since undefing leads to the default value being used.
As per zabbix's documentation this parameter is no mandatory, so undef as default value should be okay.
This Pull Request (PR) fixes the following issues
#812