puppetlabs/apache: Require 8.x; switch apache ports from string to int #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
approved these changes
Aug 9, 2022
bastelfreak
changed the title
bastelfreak
added
backwards-incompatible
and removed
bug
ekohl
reviewed
Aug 10, 2022
| @@ -18,7 +18,7 @@ | |||
| }, | |||
| { | |||
| "name": "puppetlabs/apache", | |||
| "version_requirement": ">= 1.6.0 < 7.0.0" | |||
| "version_requirement": ">= 8.0.0 < 9.0.0" | |||
There was a problem hiding this comment.
It wasn't needed to change the lower bound so strict. This can cause problems for users who haven't updated all their yet. The old versions accepted integers just fine.
There was a problem hiding this comment.
I must agree that the lower bound is quite aggressive 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Stop breaking the upstream apache rspecs.
This Pull Request (PR) fixes the following issues
Recently we started seeing:
Evaluation Error: Error while evaluating a Resource Statement, Apache::Vhost[xxx_nonssl]: parameter 'port' expects a value of type Undef, Array[Stdlib::Port = Integer[0, 65535]], or Stdlib::Port = Integer[0, 65535], got String (file: /repo/spec/fixtures/modules/zabbix/manifests/web.pp, line: 416) on node 022551739aa6.xxxThis should fix that.