Remove check for Apache 2.4/2.2, require puppetlabs/apache 9.x #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
reviewed
Jan 10, 2023
Pin max version to `10.0.0` Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
|
I think it's fine to to mark this backwards-incompatible. We deprecated CentOS 6 in the past, and that's the only OS that used Apache 2.2. |
bastelfreak
changed the title
evgeni
changed the title
|
While dropping C6 support is fine, bumping puppetlabs/apache is backwards incompatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Apache 9.0.0 release drops 2.2 support. Since Zabbix has a dependency on Apache, it makes sense to remove the comparison between >=
2.4and2.2, including setting the minimum dependency version for Apache to 9.0.0.The Zabbix module breaks if you run Apache version higher than
9.0.0, due to not being able to verify the fact.