Provide correct gpgkey for RHEL family, version > 8. #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
requested changes
Feb 11, 2023
There was a problem hiding this comment.
Thanks for the PR! Please add a spec test here to cover the new GPG key
manifests/repo.pp
Outdated
| @@ -34,8 +34,13 @@ | |||
| } | |||
| case $facts['os']['family'] { | |||
| 'RedHat': { | |||
| $gpgkey_zabbix = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591' | |||
| $gpgkey_nonsupported = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-79EA5ED4' | |||
| if $facts['os']['release']['major'] > '8' { | |||
There was a problem hiding this comment.
+1
versioncmp(fact('os.release.full'), '8.0') >= 0
There was a problem hiding this comment.
Can we move this along? :-) I tried checking out the PR and updating it but I don't seem to have the permissions to do this.
Joshua-Snapp
force-pushed
the
fix_el9_repo_gpgkey
branch
2 times, most recently
from
4e6bf2d
to
fcbc1d3
Compare
|
@root-expert Some of the tests are failing. Can you tell if it has to do with my code? Or are the failures caused by preexisting conditions. |
Joshua-Snapp
force-pushed
the
fix_el9_repo_gpgkey
branch
from
fcbc1d3
to
7783fa1
Compare
|
@Joshua-Snapp specs failures seems unrelated, something's broken in postgresql's master branch probably. Please rebase with our master branch before merging. |
Zabbix changed their gpgkey for RHEL operating systems newer than version 8. The new key works for both the "zabbix" and "zabbix_nonsupported" repos.
Joshua-Snapp
force-pushed
the
fix_el9_repo_gpgkey
branch
from
7783fa1
to
22530fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This change provides the correct gpgkey for RHEL family operating systems newer than version 8.
The new gpgkey works for both the "zabbix" and the "zabbix_nonsupported" repos.
This was successfully tested on RHEL 9.
This Pull Request (PR) fixes the following issues
Fixes #858