Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppetlabs/firewall: Require 7.x #898

Merged
merged 1 commit into from
Oct 5, 2023
Merged

puppetlabs/firewall: Require 7.x #898

merged 1 commit into from
Oct 5, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 5, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@evgeni
Copy link
Member Author

evgeni commented Oct 5, 2023

Yet another of those annoying changes.

Up to 6.0 there was an action parameter and a jump parameter, which both resulted in -J to iptables, but jump was forbidden to be accept, reject or drop:
https://github.com/puppetlabs/puppetlabs-firewall/blob/v6.0.0/lib/puppet/type/firewall.rb#L674-L679
In 7.0 the action parameter is gone in favor of jump.

@bastelfreak bastelfreak changed the title puppetlabs/firewall: Allow 7.x puppetlabs/firewall: Require 7.x Oct 5, 2023
@evgeni evgeni merged commit dbdcede into master Oct 5, 2023
27 checks passed
@evgeni evgeni deleted the firewall branch October 5, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evgeni @bastelfreak