Better Hiera compatibility #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is safe to do because it can be called even after an explicit class
statement. The following code is legal.
class { 'postgresql::server':
}
include postgresql::server
It could make a difference for a remote database, but due to the usage
of postgresql::server::pg_hba_rule that was already invalid.
The explicit require is also not needed, since postgresql::server::db
already does this where needed.
The end result is that the module is easier to use.
This is similar to the inclusion of postgresql::server if needed.
bastelfreak
approved these changes
Nov 6, 2023
ekohl
force-pushed
the
use-beaker-hiera
branch
from
77c3afc
to
b376398
Compare
|
Needs voxpupuli/voxpupuli-acceptance#77 for Puppet 8. |
ekohl
force-pushed
the
use-beaker-hiera
branch
from
b376398
to
1372a6e
Compare
By using beaker-hiera there is no need to provide it in every acceptance test.
ekohl
force-pushed
the
use-beaker-hiera
branch
from
1372a6e
to
56e30df
Compare
smortex
approved these changes
Nov 7, 2023
evgeni
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the required includes for
apacheandpostgresql::serverif needed. It then uses this together with beaker-hiera (which voxpupuli-acceptance already automatically sets up for us) to reduce duplication in acceptance tests.