Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use os.family fact to detect params #913

Merged
merged 2 commits into from Nov 8, 2023
Merged

use os.family fact to detect params #913

merged 2 commits into from Nov 8, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 8, 2023

contains #912

@evgeni
Copy link
Member Author

evgeni commented Nov 8, 2023

I think this is backwards compatible, as with Fedora removed from that list and Debian/Ubuntu updated to Debian, everything else is actually a family. And for people who did use other OSes it's not breaking as they had to set the params themself anyway

@bastelfreak bastelfreak merged commit d83836e into master Nov 8, 2023
53 checks passed
@bastelfreak bastelfreak deleted the params-family branch November 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evgeni @bastelfreak