This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
MVC Rework #83
Merged
MVC Rework #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
force-pushed
the
mvc_rework
branch
from
eed189b
to
5e8bf8f
Compare
dhollinger
commented
Dec 31, 2018
| @@ -0,0 +1,21 @@ | |||
| development: | |||
There was a problem hiding this comment.
TODO: Remove this from the repository.
dhollinger
commented
Dec 31, 2018
dhollinger
force-pushed
the
mvc_rework
branch
from
99e310b
to
6e754e6
Compare
dhollinger
force-pushed
the
mvc_rework
branch
from
f0f7a5a
to
bd05af1
Compare
dhollinger
force-pushed
the
mvc_rework
branch
from
bd05af1
to
b488963
Compare
dhollinger
force-pushed
the
mvc_rework
branch
2 times, most recently
from
31bf87f
to
19f6574
Compare
dhollinger
force-pushed
the
mvc_rework
branch
5 times, most recently
from
690478f
to
ab6f353
Compare
bastelfreak
approved these changes
Jan 23, 2019
All API routes have been moved to controllers in Api::V1::<ControllerName>. These controllers are configured to respond to their original urls for backwards compatibility. This compatibility will be removed in 2.0.0. All r10k helpers have been moved to a new R10kHelpers file in `app/helpers/r10k_helpers.rb`. All global controller methods are now private methods within the main ApplicationController, while controller-specific methods now exist in their controllers. Any non-public method is now private. All library-based code is now contained in a `PuppetWebhook` module within the `lib/` directory in the root of the codedir. Theses include body parsers, mcollective client, and chatops clients. New tests have been added for the parsers, controllers, and helpers
dhollinger
force-pushed
the
mvc_rework
branch
from
ab6f353
to
1264129
Compare
bastelfreak
approved these changes
Jan 23, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the application into a Model, View, Controller style framework without changing user-facing functionality.
Benefits:
Drawbacks: