api/v3 Adding pagination functionality for supporting endpoints #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users want to be able to browse through the history available in PuppetDB without crashing the server/client with too much information adding attributes 'order_by', 'limit' and 'offset' to the following functions: nodes facts resources reports events event_counts
Travis CI Build on this pull request filed due to trailing white-space and under-indentation of newly modified code. Details are https://travis-ci.org/puppet-community/pypuppetdb/builds/38442716
Travis CI build is still failing dur to under-indentation at the lines where the event_counts function is declared. Details are https://travis-ci.org/puppet-community/pypuppetdb/builds/38443403
|
Thank you for this! I've just started a new job so it's going to take me a few days before I can sit down to review it. |
Including the order_by, limit and offset parameters to the function fact_names. Documentation and tests show that it does support the standard pagination functions
For the function calls and definitions where the parameter list is too long and need to be appended to new lines, having each parameter in its own line. This standardizes the coding style and is compliant to python coding best practices
|
I will squash this pull-request into a single commit the next time I am able to work on it. |
|
Alright. Looking forward to the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users want to be able to browse through the history available in
PuppetDB without crashing the server/client with too much information
adding attributes 'order_by', 'limit' and 'offset' to the following
functions:
nodes
facts
resources
reports
events
event_counts