Use structured facts to detect OS version #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested at voxpupuli/puppet-letsencrypt#281 |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 96.20% 95.62% -0.58%
==========================================
Files 2 2
Lines 158 160 +2
==========================================
+ Hits 152 153 +1
- Misses 6 7 +1
Continue to review full report at Codecov.
|
This is at least required for Arch Linux on Facter 4. It doesn't have the legacy facts operatingsystemmajrelease / operatingsystemrelease. https://tickets.puppetlabs.com/projects/FACT/issues/FACT-3114
|
Instead of refactoring the whole block I decided to only inject one block that uses structured facts. I'm not sure if all factsets have them yet so I think this is the safer approach. |
TuningYourCode
approved these changes
Apr 22, 2022
ekohl
approved these changes
Apr 22, 2022
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
|
restarted voxpupuli/puppet-letsencrypt#281 with your patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is at least required for Arch Linux on Facter 4. It doesn't have
the legacy facts operatingsystemmajrelease / operatingsystemrelease.
https://tickets.puppetlabs.com/projects/FACT/issues/FACT-3114