directly load blacksmith rake tasks #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppet_blacksmith is already a dependency. We can directly load the provided rake tasks so other libs, that depend on voxpupuli-release don't need to load blacksmith as well.
|
labeled as bug because people might assume that the tasks would be loaded because it's listed as a dep in the gemspec |
ekohl
approved these changes
Jul 30, 2021
kenyon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppet_blacksmith is already a dependency. We can directly load the
provided rake tasks so other libs, that depend on voxpupuli-release
don't need to load blacksmith as well.