Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rubocop removing trailing commas from multi-line declarations #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented Feb 9, 2023

No description provided.

@jhoblitt jhoblitt added the bug Something isn't working label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 1.63% // Head: 1.63% // No change to project coverage 👍

Coverage data is based on head (fe2563f) compared to base (53011ea).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head fe2563f differs from pull request most recent head 43eb0cb. Consider uploading reports for the commit 43eb0cb to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #86   +/-   ##
======================================
  Coverage    1.63%   1.63%           
======================================
  Files           2       2           
  Lines          61      61           
======================================
  Hits            1       1           
  Misses         60      60           
Impacted Files Coverage Δ
lib/voxpupuli/test/facts.rb 2.50% <0.00%> (ø)
lib/voxpupuli/test/rake.rb 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jhoblitt jhoblitt force-pushed the bugfix/stop-removing-trailing-commas branch from fe2563f to 90386a8 Compare February 9, 2023 19:30
@jhoblitt
Copy link
Member Author

jhoblitt commented Feb 9, 2023

Rebased after the merge of #85.

spec/facts_spec.rb Outdated Show resolved Hide resolved
@jhoblitt jhoblitt force-pushed the bugfix/stop-removing-trailing-commas branch from 90386a8 to 2075929 Compare February 9, 2023 19:51
@jhoblitt jhoblitt force-pushed the bugfix/stop-removing-trailing-commas branch from 2075929 to 43eb0cb Compare February 9, 2023 19:56
@jhoblitt
Copy link
Member Author

jhoblitt commented Feb 9, 2023

rubocop in this repo is now successfully eating its own dog food...

@bastelfreak
Copy link
Member

before we merge this I think ot makes sense to have an overview of the impact. I am afraid we need to update all modules after this change is released

@jhoblitt
Copy link
Member Author

jhoblitt commented Feb 9, 2023

Ya. I've been thinking about how to incorporate rubocop into modulesync. I'm also thinking that we should be pinning the version in modules in order to prevent a massive simultaneous update in the future.

@ekohl
Copy link
Member

ekohl commented Feb 14, 2023

I'm strongly in favor of this, but it will cause changes in most modules so I'd suggest it's a major version bump. We do plan one anyway for dropping Ruby < 2.7, so perhaps we should align those.

@jhoblitt
Copy link
Member Author

I'm wondering if the right approach is to do a module sync that adds a branch name to every pupmod that pins the file to the way it is now. Then we can merge this PR and an related PR to modulesync_config that bumps the branch ref. That will put off needing to modify individual mods until the next modsync run.

@ekohl
Copy link
Member

ekohl commented Feb 14, 2023

We aim to make the module also usable outside of Vox Pupuli, so we can't control it. It must be a major version IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants