DataTableのスタイル調整 #115
Merged
DataTableのスタイル調整 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これ当時のデザインと今のDataTableのデザイン違うと思うんだけどその辺りは確認済みかな？ border-top, bottomが濃くなったから薄い方が重なると気になりそう |
|
@kinokoruumu |
|
@kinokoruumu |
kinokoruumu
approved these changes
Jul 9, 2020
| @@ -112,6 +112,7 @@ type Props<T> = { | |||
| per?: number; // perが指定されている場合、初期値がそれに強制されます | |||
| defaultSortField?: string; | |||
| defaultSortOrder?: "desc" | "asc"; | |||
| ruledLine?: boolean; | |||
There was a problem hiding this comment.
booleanっぽい名前にして欲しい！
他のだとisXX とか enableXXとかになってたはず
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35